Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back & Front - remove isStart for status action #86

Merged
merged 3 commits into from
Feb 20, 2024
Merged

Back & Front - remove isStart for status action #86

merged 3 commits into from
Feb 20, 2024

Conversation

lwih
Copy link
Collaborator

@lwih lwih commented Jan 30, 2024

C'est par rapport au fait que les commandants voulaient auto-fermer un status quand ils en créent un nouveau.
A la base, on affichait un status de début et un status de fin mais c'était vraiment galère de gérer cette fermeture avec début et fin.
Du coup, on a simplifié et on a que des statuts de début en fait.

Donc quand on remplira le rapport de patrouille, il faudra loop sur tous les statuts et compter les diff entre 2 statuts pour avoir la durée.

Copy link

github-actions bot commented Jan 30, 2024

Coverage Report for frontend

Status Category Percentage Covered / Total
🟢 Lines 80.63% / 70% 1045 / 1296
🟢 Statements 81.12% / 70% 1083 / 1335
🟢 Functions 73.83% / 70% 285 / 386
🟢 Branches 72.88% / 70% 492 / 675
File Coverage
File Stmts % Branch % Funcs % Lines Uncovered Lines
Changed Files
frontend/src/pam/mission/mission-content.tsx 55.55% 36.36% 28.57% 55.55% 37, 42, 47-49, 48, 53-59, 61-65, 68, 72, 74-80, 82-83, 194
frontend/src/pam/mission/queries.ts 100% 100% 100% 100%
frontend/src/pam/mission/actions/action-status-form.tsx 93.1% 100% 85.71% 93.1% 141-142
frontend/src/pam/mission/actions/use-action-by-id.tsx 33.33% 0% 0% 33.33% 290-293, 295-297, 296, 299
frontend/src/pam/mission/status/use-add-update-status.tsx 100% 100% 100% 100%
frontend/src/pam/mission/timeline/use-mission-timeline.tsx 83.33% 50% 100% 83.33% 71
frontend/src/pam/mission/timeline/item/timeline-item-status.tsx 100% 100% 100% 100%
frontend/src/types/action-types.ts 100% 100% 100% 100%
Generated in workflow #178

Copy link

@lwih lwih merged commit 9b94d17 into main Feb 20, 2024
13 checks passed
@lwih lwih deleted the close-status branch February 20, 2024 10:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant